Replace numeric enums with string enums#76
Open
lchudinov wants to merge 1 commit intozowe:v1.x/stagingfrom
Open
Replace numeric enums with string enums#76lchudinov wants to merge 1 commit intozowe:v1.x/stagingfrom
lchudinov wants to merge 1 commit intozowe:v1.x/stagingfrom
Conversation
Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace numeric enums with string enums
Proposed changes
This PR replaces numeric enums for
ActionTargetModeandActionTypeby string enums. This way we won't need conversion between numeric and human-readable variants of the enums.Type of change
Please delete options that are not relevant.