Skip to content

Pass service param to use on force encoding.#205

Open
Akayeshmantha wants to merge 1 commit intozowe:v1.x/stagingfrom
Akayeshmantha:patch-3
Open

Pass service param to use on force encoding.#205
Akayeshmantha wants to merge 1 commit intozowe:v1.x/stagingfrom
Akayeshmantha:patch-3

Conversation

@Akayeshmantha
Copy link
Copy Markdown
Contributor

@Akayeshmantha Akayeshmantha commented Aug 5, 2020

Pass the service object to refer in common-c method

Signed-off-by: Akayeshmantha <akayeshmantha@apache.org>
@ifakhrutdinov
Copy link
Copy Markdown
Contributor

@Akayeshmantha can you clarify the end goal of the change? That is, what are you trying to achieve?

@ifakhrutdinov ifakhrutdinov self-requested a review August 31, 2020 06:27
Copy link
Copy Markdown
Contributor

@ifakhrutdinov ifakhrutdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify the intent.

@Akayeshmantha
Copy link
Copy Markdown
Contributor Author

@ifakhrutdinov for the changes done in here zowe/zowe-common-c#160 in commons. We need to pass the service object from zss in order to capture the request params.

@ifakhrutdinov
Copy link
Copy Markdown
Contributor

The only place where the service parm is used in respondWithUnixFile2 is this

    if ((NULL != service) &&
        (NULL != service->customHeadersFunction))
    {
      service->customHeadersFunction(service, response);
    }

Can you point me to the place where you wanted to use it?

@1000TurquoisePogs
Copy link
Copy Markdown
Member

This needs a real description. Even if I know what it is right now, others don't and it's likely that a year from now if I need to review history, I won't remember.
I believe this is for the file transfer app feature where you may want to explicitly download as a particular encoding in the case that something is tagged incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

3 participants