Stop reading dataset records when JSON printer is in error state#819
Open
struga0258 wants to merge 3 commits intov3.x/stagingfrom
Open
Stop reading dataset records when JSON printer is in error state#819struga0258 wants to merge 3 commits intov3.x/stagingfrom
struga0258 wants to merge 3 commits intov3.x/stagingfrom
Conversation
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
1000TurquoisePogs
previously approved these changes
Apr 13, 2026
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
1000TurquoisePogs
approved these changes
Apr 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
When ZSS streams dataset contents via streamDataset(), the while (!feof(in)) loop continues reading every record of the dataset even if the JSON printer has already entered an error state (e.g., due to an EBCDIC conversion failure). For large datasets with unmappable characters, this causes ZSS to burn CPU reading and attempting to convert thousands of records that will all fail, producing repeated JSON: conversion error, rc 16, reason 4 messages and high CPU utilization.
This PR adds a check for jsonCheckIOErrorFlag(jPrinter) to the loop condition, so that streamDataset() stops reading records as soon as the JSON printer reports an IO error. This works in conjunction with zowe-common-c #590, which ensures the error flag is properly set when conversion fails.
Depends on: zowe/zowe-common-c#590
Type of change: Bug fix