[WIP] ZSS startup script to use HA-overriden config for that HA instance #826
Draft
Gautham-coder wants to merge 1 commit intov3.x/stagingfrom
Draft
[WIP] ZSS startup script to use HA-overriden config for that HA instance #826Gautham-coder wants to merge 1 commit intov3.x/stagingfrom
Gautham-coder wants to merge 1 commit intov3.x/stagingfrom
Conversation
…d change in cookieName behavior Signed-off-by: Gautham Kuppuswamy <gkuppuswamy@rocketsoftware.com>
|
❌ The last analysis has failed. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZSS doesnt respect HA config.
Proposed changes
Start-up ZSS with new HA overriden merged yaml created by zwe internal start prepare and made available throught environment variable ZWE_PRIVATE_HA_INSTANCE_CONFIG
Since the haInstances value is no longer available the cookieName behavior will be modified.
This PR addresses Issue: #737
This PR depends upon the following PRs: zowe/zowe-install-packaging#4759
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
./zwe start --config ../zowe.yaml --ha-instance lpar1
Before fix:
ZWES1035I ZSS Server settings: Address='0.0.0.0', port='56709', protocol='https'
After fix:
ZWES1035I ZSS Server settings: Address='0.0.0.0', port='56729', protocol='https'
Further comments