refactor(lint): ESLint config changes + mechanical code fixes#52
Merged
refactor(lint): ESLint config changes + mechanical code fixes#52
Conversation
Collaborator
saithis
commented
Mar 26, 2026
saithis
commented
- Add argsIgnorePattern/varsIgnorePattern to no-unused-vars (components)
- Allow arrow functions in no-empty-function rule
- Add checksVoidReturn.arguments:false to no-misused-promises
- Turn off no-explicit-any for spec files in components config
- Suppress no-conflicting-lifecycle in CVA+MatFormFieldControl components
- Add noop comments to empty method stubs
- Remove unused _formatTime parameter
- Remove stale eslint-disable directives
- Add argsIgnorePattern/varsIgnorePattern to no-unused-vars (components) - Allow arrow functions in no-empty-function rule - Add checksVoidReturn.arguments:false to no-misused-promises - Turn off no-explicit-any for spec files in components config - Suppress no-conflicting-lifecycle in CVA+MatFormFieldControl components - Add noop comments to empty method stubs - Remove unused _formatTime parameter - Remove stale eslint-disable directives
Replace `any` with proper types across all component source files: - CVA callbacks use component-specific value types - Provider declarations use `Provider` from @angular/core - Timer refs use `ReturnType<typeof setTimeout>` - Validate returns use `ValidationErrors` - Generic defaults changed from `<T = any>` to `<T = unknown>` - Angular Material internal access uses eslint-disable with explanation - String coercion uses `String()` instead of `(value as any) + ''`
- Migrate demo components to signal APIs (input, viewChild, contentChild) - Fix no-unsafe-* warnings with proper typing in demo - Fix select generic variance: compareWith accepts unknown params - Accept string dataSource values for custom select services - Add DemoSelectItem type for proper demo data typing
- Cast sort comparators to number for unknown-typed values in specs - Use typed generic params for ZvTableDataSource in specs - Keep getControlType as any due to duck-typing Angular Material privates
zvo-qla
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.