Clean up RSS14Reader#631
Conversation
755a2dc to
2fc10e6
Compare
|
Thank you for all the PRs, much appreciated!!! I will take a look after my vacation! 👍🏻 |
|
Can you rebase that and resolve the conflicts? |
let -> const, initialize numbers, change equality operator, add missing comments.
2fc10e6 to
724d31f
Compare
|
some tests are still failing @opl- |
|
It's been over a year and the build logs expired, but I assume the reason for the failing tests was the same as with #630 - the image manipulation library used for testing being unable to rotate or otherwise transform the test images? From what I recall the point of this PR was to fix the thrown errors getting eaten, and I happened to do some clean up and port a couple commits from the original library while at it (split into separate commits). Was never my intention to make all tests pass, so as long as this doesn't make more tests fail, I don't see a reason not to merge this. |
c10ad76
into
zxing-js:feature/modernize26
2 participants
Ported zxing/zxing#1179, changed a bunch of
lettoconstwhere appropriate, copied over a couple comments, initialized some variables, changed==to===, and fixed thrown errors getting eaten in one place.