perf: add tree processing cache to avoid redundant computations#1
Open
zyf265600 wants to merge 14 commits into
Open
perf: add tree processing cache to avoid redundant computations#1zyf265600 wants to merge 14 commits into
zyf265600 wants to merge 14 commits into
Conversation
Cache NewClassTree processing in NullnessNoInitAnnotatedTypeFactory to prevent duplicate type annotation calculations.
…rn if type already has @nonnull.
d684a53 to
da837a3
Compare
df7497d to
5bf54a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache NewClassTree processing in NullnessNoInitAnnotatedTypeFactory to prevent duplicate type annotation calculations.
Note
Adds a system property to disable the NonNull fast-path for
newclass sites and a jtreg benchmark to measure its performance impact.cf.skipNonnullFastPathinNullnessNoInitAnnotatedTypeFactoryto optionally skiphasEffectiveAnnotation(NONNULL)fast-path.visitNewClassto short-circuit when fast-path is enabled; otherwise always add missing@NonNull.checker/jtreg/nullness/perf/NewClassPerf.javato generate manynewsites and timejavacruns with/without the fast-path (-J-Dcf.skipNonnullFastPath=true).Written by Cursor Bugbot for commit 588ed47. This will update automatically on new commits. Configure here.