Selective CDR parsing (deserialize_selected); fix non-leading @key extraction - #47
Merged
Conversation
Greptile SummaryThe PR adds mask-driven selective CDR deserialization across the C, C++, Java, and Zig backends, allowing key and field extraction without fully decoding unrelated members.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains in the previously reported cursor, alignment, or overflow paths. No blocking failure remains. Important Files Changed
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
get_key_value and ContentFilteredTopic/QueryCondition field access both need a few members out of a serialized sample, but zidl had no way to parse a subset. So each backend worked around it:
The fix both needed is the same primitive: a parser that decodes the wanted members and skips the rest.
Description of changes