Conversation
Replace per-format output flags (--svg, --html, --json, --collapse, --pprof, --codeguru) with a single -o/--output flag that infers format from file extension (.svg, .html, .json, .folded, .pb.gz, .codeguru.json). Replace per-type probe flags (--kprobe, --uprobe, --tracepoint) with a single -e/--event flag using prefix syntax (kprobe:, uprobe:, tracepoint:, with short forms k:, u:, ur:, t:, tp:). Bare names default to uprobe. Legacy flags still work (hidden from --help, mentioned in examples section). Both flags are repeatable: -o a.svg -o b.html -e kprobe:fn -e uprobe:malloc
Update all example commands in README.md, docs/codeguru_format.md, and profile-bee-tui/README.md to use the new unified flags: --svg/--html/etc → -o file.svg/-o file.html --kprobe/--uprobe/--tracepoint → -e kprobe:fn/-e uprobe:spec/-e tracepoint:cat:name --time → -t, --pid → -p, --cmd → -- <command>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR refactors the profile-bee CLI interface by consolidating format-specific output flags ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace per-format output flags (--svg, --html, --json, --collapse, --pprof, --codeguru) with a single -o/--output flag that infers format from file extension (.svg, .html, .json, .folded, .pb.gz, .codeguru.json).
Replace per-type probe flags (--kprobe, --uprobe, --tracepoint) with a single -e/--event flag using prefix syntax (kprobe:, uprobe:, tracepoint:, with short forms k:, u:, ur:, t:, tp:). Bare names default to uprobe.
Legacy flags still work (hidden from --help, mentioned in examples section). Both flags are repeatable: -o a.svg -o b.html -e kprobe:fn -e uprobe:malloc
Addresses #88, #25
Summary by CodeRabbit
New Features
-o/--outputflag replaces format-specific options; output format inferred from file extension.-e/--eventflag replaces probe-specific options; probe type specified via prefixes (e.g.,uprobe:,kprobe:).-tfor time,-ffor frequency,-pfor PID.Documentation