Skip to content

refactor!: drop the HTTP facade and the dead SwiflowStore→SwiflowFetcher edge#254

Merged
zzal merged 2 commits into
mainfrom
audit/part1-dead-surface
Jul 19, 2026
Merged

refactor!: drop the HTTP facade and the dead SwiflowStore→SwiflowFetcher edge#254
zzal merged 2 commits into
mainfrom
audit/part1-dead-surface

Conversation

@zzal

@zzal zzal commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Part-1 modularization-audit fixes (findings 1 and 3).

  • BREAKING: deletes the HTTP static facade in SwiflowFetcher — eight one-line pass-throughs to HTTPClient() with zero consumers in examples or tests. Migration: HTTP.get(...)HTTPClient().get(...); signatures are otherwise identical.
  • Removes SwiflowStore's dead SwiflowFetcher dependency (import + Package.swift edge). Compile-verified unused: the target builds clean without it; the only textual match was a comment citing PR feat(fetcher): HTTPTransport seam — the client is now host-testable #160.

Whole-package swift test: 1897 tests, 350 suites, all passing.

🤖 Generated with Claude Code

zzal and others added 2 commits July 19, 2026 16:39
…her edge

Part-1 modularization audit findings. The HTTP enum was eight pure
pass-throughs to HTTPClient() with zero consumers in examples or tests;
callers construct an HTTPClient directly. PersistentStore's
SwiflowFetcher import resolved no symbols (compile-verified), so the
target dependency goes too.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Artifact Baseline This PR Δ
App.wasm 5.06 MB 5.23 MB +3.50%
App.wasm (gzip) 1.80 MB 1.87 MB +3.57%
JS runtime 54.5 KB 54.5 KB +0.00%
JS runtime (gzip) 11.3 KB 11.3 KB +0.00%
Total (gzip) 1.81 MB 1.88 MB +3.55%

✅ Within budget (≤5% growth allowed).

Baseline: Swift 6.3, WASM SDK 6.3-RELEASE, measured 2026-06-18.

@zzal
zzal merged commit 345842e into main Jul 19, 2026
6 checks passed
@zzal
zzal deleted the audit/part1-dead-surface branch July 19, 2026 20:55
zzal added a commit that referenced this pull request Jul 20, 2026
The modularization-audit release (PRs #254-#263): animateExit listener
leak, wasm32 Int traps, host-abort gates, macro guardrails, driver test
batch. Three BREAKING API cleanups (HTTP facade, LabeledField rename,
tuple-pattern @State).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant