refactor!: drop the HTTP facade and the dead SwiflowStore→SwiflowFetcher edge#254
Merged
Conversation
…her edge Part-1 modularization audit findings. The HTTP enum was eight pure pass-throughs to HTTPClient() with zero consumers in examples or tests; callers construct an HTTPClient directly. PersistentStore's SwiflowFetcher import resolved no symbols (compile-verified), so the target dependency goes too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📦 Bundle size
✅ Within budget (≤5% growth allowed). Baseline: Swift 6.3, WASM SDK 6.3-RELEASE, measured 2026-06-18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part-1 modularization-audit fixes (findings 1 and 3).
HTTPstatic facade in SwiflowFetcher — eight one-line pass-throughs toHTTPClient()with zero consumers in examples or tests. Migration:HTTP.get(...)→HTTPClient().get(...); signatures are otherwise identical.SwiflowStore's deadSwiflowFetcherdependency (import +Package.swiftedge). Compile-verified unused: the target builds clean without it; the only textual match was a comment citing PR feat(fetcher): HTTPTransport seam — the client is now host-testable #160.Whole-package
swift test: 1897 tests, 350 suites, all passing.🤖 Generated with Claude Code