ci(e2e): ignore per-demo specs in the default config; run gridboard in CI#258
Merged
Conversation
…n CI The default Playwright config serves only the counter/router/sw/ edgecases servers, but four newer specs (overlay, tabs, catalog-nav — SwiflowUIDemo; gridboard — GridBoard) were not in its testIgnore, so every labeled CI run executed them against the counter app on :3000 and failed 'element not found' — the default leg could never go green. The GridBoard smoke config was also referenced by no npm script and no CI line, leaving the per-frame-leak soak surface without any CI presence. test:gridboard now exists and runs as the e2e job's fourth leg (:3009, no port collision). Verified locally: npm run test:gridboard → 1 passed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📦 Bundle size
✅ Within budget (≤5% growth allowed). Baseline: Swift 6.3, WASM SDK 6.3-RELEASE, measured 2026-06-18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit backlog B4 (Part-6 High): the default e2e leg could never go green, and the GridBoard smoke spec was dead in CI.
playwright.config.tstestIgnore gainsoverlay.spec.ts,tabs.spec.ts,catalog-nav.spec.ts(SwiflowUIDemo-only — they already run green undertest:swiflowui) andgridboard.spec.ts— all four previously ran a second time against the counter app on :3000 and failed 'element not found' on every labeled run.package.jsongainstest:gridboard(the config existed with no script referencing it).Verified locally:
npm run test:gridboard→ 1 passed (48.9s incl. wasm build + boot).This PR carries the
run-e2elabel so the changed job actually executes.🤖 Generated with Claude Code