docs: strip audit/phase citations and change-narration from code comments#264
Merged
Conversation
…ents Comments now state the constraint the code can't express, never where it came from or what it replaced (the comments-are-constraints rule). Swept ~65 'audit V Wave-N #N' / 'Phase N' citations and the 'previously/the old/used to' narration clauses across the runtime, keeping every substantive constraint. Corrects two actively-misleading headers: ControlClass.swift described a scopedStyles overlay seam no file uses anymore (all controls go through installControlSheet), and SwiflowDOM.swift claimed it 'compiles empty' on host — it compiles fully (canImport(JavaScriptKit) is always true), so the dead #else stub is removed and the guard documented as an intent marker. Comment-only except the dead-code #else removal. Whole-package swift test: 1909 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📦 Bundle size
✅ Within budget (≤5% growth allowed). Baseline: Swift 6.3, WASM SDK 6.3-RELEASE, measured 2026-06-18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit backlog B12 + the doc half of B13.
Per [comments-are-constraints]: a comment states what the code can't express, not its provenance. This sweeps the reviewer-facing residue the audit flagged:
(audit V Wave-2 #6),(audit III Wave-2 #9),Phase 15,Phase 13b, etc. — each a self-contained token adding nothing to the constraint beside it. Every substantive sentence is kept.previously a missed hand-sync…,the old State<T> class did…,(found via GridBoard playback)— history that belongs in git, not the source. Algorithm descriptions that happen to say "previously-mounted" (i.e. describe the diff, not a change) are untouched.ControlClass.swiftdescribed ascopedStyles/CSSInjectoroverlay seam that no SwiflowUI file uses anymore (every control installs viainstallControlSheet);SwiflowDOM.swiftclaimed the target "compiles (empty)" on host when it compiles fully (canImport(JavaScriptKit)is unconditionally true) — the dead#else public enum Swiflow {}stub is removed and the always-true guard documented as an intent marker.54 files, +105/−136. Comment-only except the dead-code
#elseremoval. Whole-packageswift test: 1909 green.🤖 Generated with Claude Code