Skip to content

refactor: group internal non-product targets under Sources/_support/#268

Merged
zzal merged 1 commit into
mainfrom
refactor/group-internal-targets
Jul 20, 2026
Merged

refactor: group internal non-product targets under Sources/_support/#268
zzal merged 1 commit into
mainfrom
refactor/group-internal-targets

Conversation

@zzal

@zzal zzal commented Jul 20, 2026

Copy link
Copy Markdown
Owner

What

Moves the three non-product build-scaffolding targets — SwiflowCSSCore, SwiflowEmbedders, MacroConsumerChecks — under Sources/_support/.

Why

Sources/ had 16 flat directories, implying 16 modules to learn. Only 12 are products (importable libraries/executables) plus SwiflowMacrosPlugin (the compiler plugin, kept visible by convention). The other three are internal scaffolding: a zero-dep CSS-rules leaf, the codegen emit logic, and a plain-swift build compile gate. Grouping them under _support/ (sorts to the bottom) makes the top level read as the public catalogue.

Scope

Pure relocation via git mv (history-preserving renames):

  • Only the three path: strings in Package.swift change.
  • Target/product graph is byte-identical: 29 targets, 12 products.
  • No CI workflow, script, or test target references these paths (verified — CI's Sources/ refs touch only product targets + SwiflowCLI).
  • Dropped the now-stale // Sources/<Target>/File.swift path-echo header lines from the moved files.

Verification

  • swift build clean.
  • Full suite: 1922 tests / 356 suites passed (8 pre-existing withKnownIssue markers, no regressions).

🤖 Generated with Claude Code

The three build-scaffolding targets that are NOT products — SwiflowCSSCore,
SwiflowEmbedders, MacroConsumerChecks — now live under Sources/_support/ so
the Sources/ top level reads as the public catalogue (the 12 products plus
the SwiflowMacrosPlugin compiler plugin) rather than 16 sibling directories
that imply 16 modules to learn.

Pure relocation: only the three `path:` strings in Package.swift change, the
target/product graph is byte-identical (29 targets, 12 products), and no CI
workflow, script, or test target references these paths (verified). Stale
`// Sources/<Target>/File.swift` path-echo header lines dropped from the moved
files. Full suite: 1922 tests / 356 suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Artifact Baseline This PR Δ
App.wasm 5.06 MB 5.23 MB +3.46%
App.wasm (gzip) 1.80 MB 1.87 MB +3.56%
JS runtime 54.5 KB 54.5 KB +0.00%
JS runtime (gzip) 11.3 KB 11.3 KB +0.00%
Total (gzip) 1.81 MB 1.88 MB +3.54%

✅ Within budget (≤5% growth allowed).

Baseline: Swift 6.3, WASM SDK 6.3-RELEASE, measured 2026-06-18.

@zzal
zzal merged commit f6710f8 into main Jul 20, 2026
6 checks passed
@zzal
zzal deleted the refactor/group-internal-targets branch July 20, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant