refactor: group internal non-product targets under Sources/_support/#268
Merged
Conversation
The three build-scaffolding targets that are NOT products — SwiflowCSSCore, SwiflowEmbedders, MacroConsumerChecks — now live under Sources/_support/ so the Sources/ top level reads as the public catalogue (the 12 products plus the SwiflowMacrosPlugin compiler plugin) rather than 16 sibling directories that imply 16 modules to learn. Pure relocation: only the three `path:` strings in Package.swift change, the target/product graph is byte-identical (29 targets, 12 products), and no CI workflow, script, or test target references these paths (verified). Stale `// Sources/<Target>/File.swift` path-echo header lines dropped from the moved files. Full suite: 1922 tests / 356 suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📦 Bundle size
✅ Within budget (≤5% growth allowed). Baseline: Swift 6.3, WASM SDK 6.3-RELEASE, measured 2026-06-18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the three non-product build-scaffolding targets —
SwiflowCSSCore,SwiflowEmbedders,MacroConsumerChecks— underSources/_support/.Why
Sources/had 16 flat directories, implying 16 modules to learn. Only 12 are products (importable libraries/executables) plusSwiflowMacrosPlugin(the compiler plugin, kept visible by convention). The other three are internal scaffolding: a zero-dep CSS-rules leaf, the codegen emit logic, and a plain-swift buildcompile gate. Grouping them under_support/(sorts to the bottom) makes the top level read as the public catalogue.Scope
Pure relocation via
git mv(history-preserving renames):path:strings inPackage.swiftchange.Sources/refs touch only product targets +SwiflowCLI).// Sources/<Target>/File.swiftpath-echo header lines from the moved files.Verification
swift buildclean.withKnownIssuemarkers, no regressions).🤖 Generated with Claude Code