fix(install,doctor): strip model: for opencode agents; dedup doctor settingsFiles - #10
Merged
Merged
Conversation
…ettingsFiles Two runtime bugs found while deep-testing eapcrew across hosts. 1. opencode crew subagents that pin `model: haiku` fail to spawn with "Model not found: haiku/." when opencode has no Anthropic provider authed (only the builder agents, which carry no `model:`, spawn). This re-applies the `model:` strip that #9 removed: #9 assumed keeping `model:` was safe (opencode accepts it as a field and its config loads) — but at spawn time the unresolved Anthropic alias errors. installNativeAssets now strips `model:` in addition to the tools array when writing eapcrew agents into opencode, so they inherit opencode's default model. Claude Code still keeps both fields. 2. eap_doctor listed ~/.claude/settings.json twice when cwd == home (the home and cwd candidate paths collided with no dedup). Dedup the candidate list. Cosmetic — events/ok were already correct. 223/223 tests pass. Verified: opencode eapcrew agents emit no `tools:`/`model:`; eap_doctor returns a single settingsFiles entry from cwd=home.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two runtime bugs found deep-testing eapcrew across all 9 agents.
1. opencode crew subagents can't spawn (
model: haiku) — investigator/reviewer pinmodel: haiku; when opencode has no Anthropic provider authed they fail withModel not found: haiku/.(only builder agents, which carry nomodel:, spawn). Re-applies themodel:strip that #9 removed — #9 assumed keeping it was safe (opencode accepts it as a field, config loads), but at spawn time the unresolved Anthropic alias errors.installNativeAssetsnow stripsmodel:alongside the tools array for opencode; the agents inherit opencode's default model. Claude keeps both.2. eap_doctor duplicate settingsFiles — listed
~/.claude/settings.jsontwice when cwd==home (home + cwd candidates collided, no dedup). Deduped. Cosmetic.Verified: 223/223 tests; opencode eapcrew emit no
tools:/model:;eap_doctorreturns one settingsFiles entry from cwd=home.