Remove google.cloud.logging from package#76
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_751170764
branch
from
3d95666 to
c67e0ff
Compare
It should be up to the workload whether structured logs and integration with Cloud Logging is used. In addition, `google.cloud.logging.Client.setup_logging()` was being called after other logs were made via dependencies. These other logs would create a `StreamHandler` that prints logs to stderr since no handler existed. Then `setup_logging` would add a `StructuredLogHandler` meaning there were two handlers resulting in duplicate logs. PiperOrigin-RevId: 751175001
copybara-service
Bot
force-pushed
the
test_751170764
branch
from
c67e0ff to
29c53b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
google.cloud.loggingfrom packageIt should be up to the workload whether structured logs and integration with Cloud Logging is used.
In addition,
google.cloud.logging.Client.setup_logging()was being called after other logs were made via dependencies. These other logs would create aStreamHandlerthat prints logs to stderr since no handler existed. Thensetup_loggingwould add aStructuredLogHandlermeaning there were two handlers resulting in duplicate logs.