Skip to content

Remove google.cloud.logging from package #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 24, 2025
Merged

Remove google.cloud.logging from package #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pathwaysutils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import os

import jax
from pathwaysutils import cloud_logging
from pathwaysutils import profiling
from pathwaysutils import proxy_backend
from pathwaysutils.persistence import orbax_handler
Expand Down Expand Up @@ -101,13 +100,6 @@ def initialize() -> None:
# compilation cache.
jax.config.update("jax_enable_compilation_cache", False)

try:
cloud_logging.setup()
except Exception as error: # pylint: disable=broad-except
_logger.debug(
"Failed to set up cloud logging due to the following error: %s",
error,
)
else:
_logger.debug(
"Did not detect Pathways-on-Cloud backend. No changes applied."
Expand Down
21 changes: 0 additions & 21 deletions pathwaysutils/cloud_logging.py
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions pathwaysutils/test/pathwaysutils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,31 +15,19 @@
import os
from unittest import mock

import google.cloud.logging
import jax
import pathwaysutils
from pathwaysutils import cloud_logging

from absl.testing import absltest
from absl.testing import parameterized


class PathwaysutilsTest(parameterized.TestCase):

def setUp(self):
super().setUp()
self.mock_setup_logging = mock.patch.object(
cloud_logging, "setup", autospec=True
)

def test_first_initialize(self):
jax.config.update("jax_platforms", "proxy")
pathwaysutils._initialization_count = 0

self.enter_context(
mock.patch.object(google.cloud.logging, "Client", autospec=True)
)

with self.assertLogs(pathwaysutils._logger, level="DEBUG") as logs:
pathwaysutils.initialize()

Expand Down