Merged
Conversation
amrc-benmorrow
requested changes
Mar 12, 2026
Contributor
amrc-benmorrow
left a comment
amrc-benmorrow
left a comment
There was a problem hiding this comment.
This is pretty good; most of the structure is correct. There are a few systematic problems where you haven't understood the dump format correctly, but although I think I remember documenting it at some point I honestly couldn't tell you where that document is, so you must have been purely working from the examples.
You obviously haven't tried to build the image or load it into an ACS instance, or some of these problems would have been more obvious. We need to go over how to do that.
You've missed out the MES class 🙃. (Though strictly speaking this might be part of Kavan's work rather than yours.)
amrc-za
force-pushed
the
za/data-access
branch
2 times, most recently
from
2f4c9c7 to
4e06726
Compare
amrc-benmorrow
approved these changes
Mar 19, 2026
amrc-benmorrow
added a commit
that referenced
this pull request
Mar 25, 2026
amrc-benmorrow
added a commit
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.