Repository navigation
Ensure corner ghost cells where periodic meets a physical bc are - #208
Merged
asalmgren merged 1 commit intoAug 19, 2026
Merged
Conversation
correctly filled in update_velocity/tracer/temperature. Even if corner ghost cells aren't used in the diffusive stencil, not filling periodic cells before call to fillphysbc leads to failure with DEBUG and amrex.fpe_trap_invalid = 1.
asalmgren
approved these changes
Aug 19, 2026
asalmgren
enabled auto-merge (squash)
August 19, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correctly filled in update_velocity/tracer/temperature.
Even if corner ghost cells aren't used in the diffusive stencil, not filling periodic cells before call to fillphysbc leads to failure with DEBUG and amrex.fpe_trap_invalid = 1.