Skip to content

Ensure corner ghost cells where periodic meets a physical bc are #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asalmgren merged 1 commit into from
Aug 19, 2026
Merged

Ensure corner ghost cells where periodic meets a physical bc are #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/incflo_update_temperature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ void incflo::update_temperature (StepType step_type, Vector<MultiFab>& tem_eta,
{
const int ng_diffusion = 1;
for (int lev = 0; lev <= finest_level; ++lev) {
// Periodic fill necessary for corner ghost cells when physbc and periodic touch
m_leveldata[lev]->temperature.FillBoundary(geom[lev].periodicity());
fillphysbc_temperature(lev, new_time, m_leveldata[lev]->temperature, ng_diffusion);
}
Real dt_diff = (m_diff_type == DiffusionType::Implicit) ? m_dt : Real(0.5)*m_dt;
Expand Down
5 changes: 4 additions & 1 deletion src/incflo_update_tracer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@ void incflo::update_tracer (StepType step_type, Vector<MultiFab>& tra_eta, Vecto
if (m_diff_type == DiffusionType::Crank_Nicolson || m_diff_type == DiffusionType::Implicit)
{
const int ng_diffusion = 1;
for (int lev = 0; lev <= finest_level; ++lev)
for (int lev = 0; lev <= finest_level; ++lev) {
// Periodic fill necessary for corner ghost cells when physbc and periodic touch
m_leveldata[lev]->tracer.FillBoundary(geom[lev].periodicity());
fillphysbc_tracer(lev, new_time, m_leveldata[lev]->tracer, ng_diffusion);
}

Real dt_diff = (m_diff_type == DiffusionType::Implicit) ? m_dt : Real(0.5)*m_dt;
diffuse_scalar(get_tracer_new(), get_density_new(), GetVecOfConstPtrs(tra_eta), dt_diff);
Expand Down
3 changes: 3 additions & 0 deletions src/incflo_update_velocity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,10 @@ void incflo::update_velocity (StepType step_type, Vector<MultiFab>& vel_eta, Vec
{
const int ng_diffusion = 1;
for (int lev = 0; lev <= finest_level; ++lev) {
// Periodic fill necessary for corner ghost cells when physbc and periodic touch
m_leveldata[lev]->velocity.FillBoundary(geom[lev].periodicity());
fillphysbc_velocity(lev, new_time, m_leveldata[lev]->velocity, ng_diffusion);
m_leveldata[lev]->density.FillBoundary(geom[lev].periodicity());
fillphysbc_density (lev, new_time, m_leveldata[lev]->density , ng_diffusion);
}

Expand Down
Loading