fix(sandbox: Suppress mypy attr-defined error on Windows for resource.setrlimit - #4
Merged
Merged
Conversation
…etrlimit (Windows has no resource module)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the design, documentation, and robustness of the
patchwork/tools/sandbox.pymodule, focusing on subprocess isolation, logging, and cross-platform compatibility. The most important changes are:Design and Documentation Improvements:
Code Robustness and Cross-platform Compatibility:
_limit_subprocess_memoryfunction to include atype: ignorecomment for mypy, clarifying that theresourcemodule is only used on POSIX systems and ensuring type checking compatibility on Windows.Code Organization: