Skip to content

fix(sandbox: Suppress mypy attr-defined error on Windows for resource.setrlimit #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abdurrafay19 merged 1 commit into from
Sep 5, 2026
Merged

fix(sandbox: Suppress mypy attr-defined error on Windows for resource.setrlimit #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions patchwork/tools/sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@
suite (both as strings), execute the tests in an isolated temporary
directory via `pytest`, and return a strictly-typed, truncated result.

Design goals (see `critical_engineering_and_execution_advice`):
* Every subprocess call is time-boxed. A hallucinated `while True:`
in generated test code must never hang the agent process.
* Generated code/tests are never written into the project directory.
Every run gets a disposable `tempfile.TemporaryDirectory()`.
* Tool output is truncated before it re-enters the LLM context window,
to protect the ~1.5 GB VRAM KV-cache budget on a 4 GB GPU.
* Structured logging only -- no `print()`. This module logs via the
standard `logging` module with structured `extra` fields; JSON
formatting is configured by the application entrypoint, keeping
telemetry concerns decoupled from this tool's core logic.
"""

from __future__ import annotations
Expand All @@ -28,7 +39,7 @@

logger = logging.getLogger("patchwork.tools.sandbox")

# --- Constants
# --- Tunables -------------------------------------------------------------

DEFAULT_TIMEOUT_SEC: Final[int] = 10
MAX_OUTPUT_CHARS: Final[int] = 1000
Expand Down Expand Up @@ -150,7 +161,11 @@ def _limit_subprocess_memory() -> None:
import resource # POSIX-only; imported lazily so Windows never touches it.

limit_bytes = MAX_MEMORY_MB * 1024 * 1024
resource.setrlimit(resource.RLIMIT_AS, (limit_bytes, limit_bytes))
# mypy on Windows has no `resource` stub at all (module doesn't exist
# there) -- this function is only ever called on POSIX, guarded by
# platform.system() at the call site, but mypy checks function bodies
# statically regardless of that runtime guard. Safe to ignore here.
resource.setrlimit(resource.RLIMIT_AS, (limit_bytes, limit_bytes)) # type: ignore[attr-defined, unused-ignore]


@contextmanager
Expand Down Expand Up @@ -294,4 +309,4 @@ def run_pytest_sandbox(
passed=False,
duration_sec=duration,
error_message=f"pytest executable not found: {exc}",
)
)
Loading