Skip to content

Feat/review test feedback loop complete#3022

Open
Vaibhaav-Tiwari wants to merge 10 commits into
mainfrom
feat/review-test-feedback-loop-complete
Open

Feat/review test feedback loop complete#3022
Vaibhaav-Tiwari wants to merge 10 commits into
mainfrom
feat/review-test-feedback-loop-complete

Conversation

@Vaibhaav-Tiwari

Copy link
Copy Markdown
Collaborator

• ## Summary

Adds the runtime test-gate feedback loop for review automation. After a review agent submits findings, AO can now persist those findings, run runtime
verification, fuse the test evidence with the reviewer verdict, and send the final actionable feedback back to the worker.

Also includes hardening for the submit flow, baseline reuse, severity validation, and fused verdict display in the SessionInspector Reviews tab.

Testing

  • go test ./internal/testgate ./internal/storage/sqlite ./internal/storage/sqlite/store ./internal/service/review ./internal/review ./internal/httpd/ controllers ./internal/cli ./internal/daemon ./internal/httpd/apispec/... ./internal/service/project
  • go vet ./internal/testgate ./internal/storage/sqlite/store ./internal/service/review ./internal/review ./internal/httpd/controllers ./internal/cli ./ internal/daemon ./internal/httpd/apispec/... ./internal/service/project
  • npm.cmd run typecheck
  • npm.cmd run test -- src/renderer/components/SessionInspector.test.tsx src/renderer/lib/command-palette.test.ts
  • git diff --check

@AllBeingsFuture

Copy link
Copy Markdown

Could not push to head feat/review-test-feedback-loop-complete (no write access). Superseding CI-fix PR opened with rebase onto main + migration renumber (0029→0030) + prettier/lint fixes:

#3030

@AllBeingsFuture

Copy link
Copy Markdown

Superseding PR (writable fork head): #3031

@AllBeingsFuture

Copy link
Copy Markdown

Cannot update this head (expected)

Push to feat/review-test-feedback-loop-complete returns 403 for AllBeingsFuture.

These CI failures on this PR are unchanged because the original head was never updated:

Failure Root cause Fix (on superseding PR)
format Prettier on SessionInspector.tsx formatted
lint revive comments on testgate + unused reviewResults fixed
native / build-test goose dual 0025 + this branch’s 0029 test-gate migration session_cleanup_facts0029, test-gate → 0030

Please review / merge the superseding PR instead:

#3031

Branch: AllBeingsFuture:fix/3022-ci-hygiene-renumber (includes full feature + CI hygiene, rebased on main).

@AllBeingsFuture

Copy link
Copy Markdown

Canonical superseding PR: #3031

Cannot push to this head (feat/review-test-feedback-loop-complete) — no write access. CI fixes (Prettier SessionInspector, testgate revive comments, unused reviewResults, migration renumber off 0029 → 0030+) live on #3031 only. #3030 was closed as a duplicate of #3031.

@Vaibhaav-Tiwari
Vaibhaav-Tiwari force-pushed the feat/review-test-feedback-loop-complete branch from 012dc5e to c2a7b7f Compare July 23, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants