fix(ci): green review test-gate feedback loop (#3022)#3030
Closed
AllBeingsFuture wants to merge 4 commits into
Closed
fix(ci): green review test-gate feedback loop (#3022)#3030AllBeingsFuture wants to merge 4 commits into
AllBeingsFuture wants to merge 4 commits into
Conversation
Rebase onto main, renumber test-gate migration to 0030 (and dual-0025 session_cleanup to 0029), add revive comments, drop unused reviewResults, and prettier-format SessionInspector.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes / unblocks CI for #3022 (review test-gate feedback loop). Cannot push to the original head (
feat/review-test-feedback-loop-complete).mainsession_cleanup_facts→0029(same as fix(storage): renumber duplicate migration 0025 to 0029 #3014)0029→0030_test_gate_artifactsSessionInspector.tsxtestgatereviewResultsinservice/reviewRelated
Testing
go test ./internal/testgate ./internal/service/review ./internal/storage/sqlite ./internal/storage/sqlite/storenpx prettier@3 --check frontend/src/renderer/components/SessionInspector.tsxRisks / follow-ups
0029_session_cleanup_factsrename should be a no-op conflict to resolve by keeping one copy