Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy 13-byte physical status notifications were cached and logged by
TcpServer.OnBleNotify, then discarded by an early return. Java therefore received link metadata (0x82) but never the original physical response (0x81), and repeatedly rebuilt its transport after the physical-status timeout.Keep the cache update and forward the original frame through the existing notification path. Add TCP/payload, physical-status and freshness/recovery diagnostics, a C# loopback regression and two Java regressions. Connection metadata still cannot satisfy physical freshness; recovery, session/timing checks and USB behavior remain unchanged. The protocol trace and packet layouts are documented in
docs/windows-ble-physical-status.md.Validation on an independent checkout of
eternal-dev:mvn -f ahakeyconfig-win-java/pom.xml '-Dtest=BleManager*Test,PhysicalStatusFreshnessTest,TaskActivityServiceTest,AhaKeyProtocolTest,UsbHidTransport*Test' package— 47 tests passed; release contents OK.BLE_tcp_bridge/tests/Test-PhysicalStatus.ps1— production TCP/protocol loopback regression passed.MSBuild BLE_tcp_bridge/BLE_tcp_driver.csproj /restore /p:Configuration=Release— passed.Known limits: legacy
0x98/0x9Fempty ACKs are a separate capability/readback incompatibility. An earlier full-suite run also exposed an existing CRLF-sensitive source assertion; the focused regression above is green. This PR contains no firmware, application binaries or raw device logs.Conflict resolution against eternal-dev a878f63: upstream transport snapshots, receiver/session checks and lastStatusUpdateNanos are preserved together with physical-status diagnostics. Full Maven package passed 344 tests; MSBuild Release and BLE physical-status loopback regression passed. Source-inspection tests normalize CRLF; isolated temp directories prevent parallel GIF extraction collisions. No firmware or installed application changes.