Pass Turbolinks Visit Directly into Vike navigate() #61
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajinchu
changed the title
dajinchu
commented
Jan 28, 2026
| if (typeof window !== "undefined" && pageContext.isClientSide) { | ||
| const Turbolinks = window.Turbolinks; | ||
|
|
||
| let currentVisit = Turbolinks.controller.currentVisit; |
Collaborator
Author
There was a problem hiding this comment.
If Vike does any async between our call to navigate() above and executing onBeforeRoute hook, then it is possible to grab the wrong visit here.
This PR fixes that.
reinabo
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this definitely makes any difference, but reduces any possibility of race condition between
navigatecalls, if there is anyawaitbetweennavigate()andonBeforeRoute()within Vike implementation.