Skip to content

Pass Turbolinks Visit Directly into Vike navigate() #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dajinchu merged 1 commit into from
Jan 29, 2026
+2 −1
Merged

Pass Turbolinks Visit Directly into Vike navigate() #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bifrost/lib/turbolinks/visit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export class Visit {
const url = new URL(this.location.toString(), this.location.getOrigin());
navigate(url.pathname + url.hash + url.search, {
overwriteLastHistoryEntry: this.action === "replace",
pageContext: { _turbolinksVisit: this },
}).catch(console.error);
this.progress = 0;
this.requestInFlight = true;
Expand Down
2 changes: 1 addition & 1 deletion bifrost/renderer/onBeforeRoute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const onBeforeRoute = (pageContext: PageContext) => {
if (typeof window !== "undefined" && pageContext.isClientSide) {
const Turbolinks = window.Turbolinks;

let currentVisit = Turbolinks.controller.currentVisit;
Copy link
Collaborator Author

@dajinchu dajinchu Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Vike does any async between our call to navigate() above and executing onBeforeRoute hook, then it is possible to grab the wrong visit here.

This PR fixes that.

let currentVisit = pageContext._turbolinksVisit;

if (pageContext.isHistoryNavigation) {
const snapshot = Turbolinks.controller.getCachedSnapshotForLocation(
Expand Down