feat: 优化翻译#641
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (23)
Summary by CodeRabbit发布说明
Walkthrough将客户端下载卡片的标题改为 i18n 键、在资源卡内新增 macOS Enhanced 项并移除重复条目；为多语言 locale 添加相应 resource_card 键；同时更新 useBackground 的默认图片 URL 与背景尺寸行为。 变更内容Vue 组件国际化重构
预计代码审查工作量🎯 3 (中等) | ⏱️ ~20 分钟 可能相关的 PR
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src_assets/common/assets/web/components/common/ResourceCard.vue`:
- Around line 143-148: The external anchor in ResourceCard.vue (the <a> with
class "resource-link resource-link-apple" and target="_blank") lacks a rel
attribute; update that anchor to include rel="noopener noreferrer" to prevent
window.opener exploitation when opening the external GitHub link; locate the
anchor by its class "resource-link-apple" or the href
"https://github.com/skyhua0224/moonlight-macos-enhanced" and add the rel
attribute alongside the existing target.
In `@src_assets/common/assets/web/components/SetupWizard.vue`:
- Around line 259-262: The anchor element with class "resource-link
resource-link-apple" currently opens in a new tab via target="_blank" without
safe attributes; update the <a> element that links to
"https://github.com/skyhua0224/moonlight-macos-enhanced" (the resource-link
resource-link-apple anchor) to include rel="noopener noreferrer" alongside
target="_blank" to prevent reverse tabnabbing and ensure safe external linking.
In `@src_assets/common/assets/web/public/assets/locale/en.json`:
- Around line 678-679: 新增的翻译键 resource_card.moonlight_ohos 和
resource_card.moonlight_ohos_desc 只出现在 en.json，需要在其它语言包（例如
pl.json、tr.json、de.json）中补齐相同键以避免回退或 key 回显；在各对应 locale 文件中按现有 resource_card
对象结构添加这两个键，首选填入相应翻译，暂无法翻译时请使用英文文案作为占位，并确保 JSON
格式合法、键名精确匹配（resource_card.moonlight_ohos / resource_card.moonlight_ohos_desc）。
In `@src_assets/common/assets/web/public/assets/locale/ja.json`:
- Line 665: The value for the key "moonlight_macos_enhanced_desc" includes a
Chinese wording ("强化版"); update the string to a full Japanese phrasing to avoid
mixed-language UI, e.g. replace the current value with a proper Japanese
sentence such as "by skyhua0224 · macOS ネイティブで強化されたクライアント" (or another
equivalent natural Japanese translation), ensuring the key name
"moonlight_macos_enhanced_desc" is left unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5e672f60-de6d-4aa2-a1f4-d660492ebdbb
📒 Files selected for processing (22)
src_assets/common/assets/web/components/SetupWizard.vuesrc_assets/common/assets/web/components/common/ResourceCard.vuesrc_assets/common/assets/web/public/assets/locale/bg.jsonsrc_assets/common/assets/web/public/assets/locale/cs.jsonsrc_assets/common/assets/web/public/assets/locale/de.jsonsrc_assets/common/assets/web/public/assets/locale/en.jsonsrc_assets/common/assets/web/public/assets/locale/en_GB.jsonsrc_assets/common/assets/web/public/assets/locale/en_US.jsonsrc_assets/common/assets/web/public/assets/locale/es.jsonsrc_assets/common/assets/web/public/assets/locale/fr.jsonsrc_assets/common/assets/web/public/assets/locale/it.jsonsrc_assets/common/assets/web/public/assets/locale/ja.jsonsrc_assets/common/assets/web/public/assets/locale/ko.jsonsrc_assets/common/assets/web/public/assets/locale/pl.jsonsrc_assets/common/assets/web/public/assets/locale/pt.jsonsrc_assets/common/assets/web/public/assets/locale/pt_BR.jsonsrc_assets/common/assets/web/public/assets/locale/ru.jsonsrc_assets/common/assets/web/public/assets/locale/sv.jsonsrc_assets/common/assets/web/public/assets/locale/tr.jsonsrc_assets/common/assets/web/public/assets/locale/uk.jsonsrc_assets/common/assets/web/public/assets/locale/zh.jsonsrc_assets/common/assets/web/public/assets/locale/zh_TW.json
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
src_assets/**/*.{vue,js,html}
⚙️ CodeRabbit configuration file
src_assets/**/*.{vue,js,html}: 基于 Vue.js 的 Web 配置面板。审查 XSS/CSRF 安全性、 组件设计、状态管理和可访问性。
Files:
src_assets/common/assets/web/components/SetupWizard.vuesrc_assets/common/assets/web/components/common/ResourceCard.vue
🔇 Additional comments (15)
src_assets/common/assets/web/public/assets/locale/zh_TW.json (1)
651-666: 本段新增的resource_card本地化键实现正确。键名与现有 i18n 结构一致，文案可用于资源卡标题/描述渲染，且未破坏 JSON 结构。
src_assets/common/assets/web/public/assets/locale/bg.json (1)
651-666: 保加利亚语资源卡新增键与多语言键集保持一致。这组新增键覆盖了新资源卡场景，结构与命名规范统一，变更可接受。
src_assets/common/assets/web/public/assets/locale/pt_BR.json (1)
651-666: pt_BR 新增翻译键设计合理，落地完整。新增字段与资源卡展示需求匹配，键名一致性良好，可直接用于前端渲染。
src_assets/common/assets/web/public/assets/locale/en_GB.json (1)
651-666: en_GB 的新增资源卡翻译键完整且可用。新增 key 覆盖新 UI 文案点，命名稳定，符合当前 locale 结构。
src_assets/common/assets/web/public/assets/locale/es.json (1)
651-666: es 资源卡新增键与组件需求匹配，未见结构风险。该变更可支持新卡片标题与描述的国际化渲染，整体实现通过。
src_assets/common/assets/web/public/assets/locale/pt.json (1)
651-651: 新增的resource_card翻译键结构正确且与现有命名保持一致。这些新增键与同模块命名风格一致，且 JSON 语法完整，能够安全支持新资源卡片文案渲染。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/uk.json (1)
651-651:resource_card新增键覆盖完整，变更范围清晰。本次新增项与其他语言文件保持同一键集合，便于前端统一按 key 渲染，未发现语法或结构问题。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/sv.json (1)
651-651: 瑞典语资源卡片新增翻译键实现良好。键名、层级与现有
resource_card保持一致，新增内容可直接被现有 i18n 流程消费。Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/it.json (1)
651-651: 意大利语文件中的新增 i18n 键与目标功能匹配。新增字段集中、可读性好，未引入格式错误或潜在运行风险。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/cs.json (1)
651-651: 新增资源卡翻译键结构正确，和现有 i18n 组织方式保持一致。这些键位于正确的命名空间下，命名与用途清晰，可直接支撑新增资源卡片文案渲染。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/ko.json (1)
651-651: 韩文本地化新增键与其他语言版本对齐，落位正确。键名和分组一致，便于多语言资源卡统一渲染，当前改动看起来可靠。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/fr.json (1)
651-651: 法语资源卡新增文案键设计合理，兼容现有 i18n 结构。这组新增键完整覆盖了新增卡片需要的标题/描述字段，改动方向正确。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/ru.json (1)
651-651: 俄语 locale 的新增资源卡键保持了良好的跨语言一致性。键路径与命名规范符合当前文件模式，可稳定支撑对应 UI 文案。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/en_US.json (1)
651-651: en_US 基线文案键补充完整，适合作为多语言对齐参考。新增键命名清晰、结构稳定，能够支持新增资源卡的 i18n 引用。
Also applies to: 664-666
src_assets/common/assets/web/public/assets/locale/de.json (1)
664-666: 该处无需重复评论
resource_card键一致性问题已在src_assets/common/assets/web/public/assets/locale/en.json的根因位置集中指出。
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.