AB#8166 group field -> org field#767
Conversation
| @opt_field_name() | ||
| def group_remove_field(identifier, field_names): | ||
| ''' | ||
| Deny fields from showing for the given org. |
There was a problem hiding this comment.
Suggest wording like "Remove fields from the data view for the given org", and above "Add fields to... " - just because deny sounds strange in the context of their own data. Wording is a little odd regardless really, was inherited from groups I assume
There was a problem hiding this comment.
Yeah agreed. I just git mv'd it from group/field, but I agree it sounds strange
| def list_field(identifier: str, out_format: str, view_type: str): | ||
| compact_fields = [ | ||
| "columnName", | ||
| "metaDataColumnTypeName", |
There was a problem hiding this comment.
Have we got metaDataColumnTypeName as a property throughout the rest of the CLI? If we do then we should just fix them all at once (and maybe backend too) but if not, I think it's worth renaming the first two properties to field and fieldType which matches the names of the commands themselves
There was a problem hiding this comment.
Almost of all our DTOs have metaDataColumn* rather than field*. I'll make a separate card for it. I think we'll probably want to rename the tables as well
There was a problem hiding this comment.
Yeah we do, there is a cleanup card for that
|
@samcarswell does the |
2 participants
https://github.com/AusTrakka/austrakka-portal/pull/2389
PR Checklist
Double check the repo merge order here
if you have companion PRs in other repositories.