-
Notifications
You must be signed in to change notification settings - Fork 0
AB#8166 group field -> org field
#767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samcarswell
wants to merge
4
commits into
Development
Choose a base branch
from
8166-org-field
base: Development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import click | ||
|
|
||
| from austrakka.utils.output import table_format_option | ||
| from austrakka.utils.cmd_filter import hide_admin_cmds | ||
| from austrakka.utils.options import * | ||
| from .funcs import \ | ||
| add_field, \ | ||
| remove_field, \ | ||
| list_field | ||
|
|
||
|
|
||
| @click.group() | ||
| @click.pass_context | ||
| def field(ctx): | ||
| """Commands related to org fields""" | ||
| ctx.context = ctx.parent.context | ||
|
|
||
|
|
||
| @field.command('add', hidden=hide_admin_cmds()) | ||
| @opt_identifier(help="Org identifier") | ||
| @opt_field_name() | ||
| def group_add_field(identifier, field_names): | ||
| ''' | ||
| Add fields to the data view for the given org | ||
| ''' | ||
| add_field(identifier, field_names) | ||
|
|
||
|
|
||
| @field.command('remove', hidden=hide_admin_cmds()) | ||
| @opt_identifier(help="Org identifier") | ||
| @opt_field_name() | ||
| def group_remove_field(identifier, field_names): | ||
| ''' | ||
| Remove fields from the data view for the given org | ||
| ''' | ||
| remove_field(identifier, field_names) | ||
|
|
||
|
|
||
| @field.command('list', hidden=hide_admin_cmds()) | ||
| @opt_identifier(help="Org identifier") | ||
| @table_format_option() | ||
| @opt_view_type() | ||
| def group_list_field(identifier: str, out_format: str, view_type: str): | ||
| ''' | ||
| List of fields in data view for the given org | ||
| ''' | ||
| list_field(identifier, out_format, view_type) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| from typing import List | ||
|
|
||
| from austrakka.utils.api import api_patch | ||
| from austrakka.utils.misc import logger_wraps | ||
| from austrakka.utils.output import get_viewtype_columns | ||
| from austrakka.utils.paths import ORG_V2_PATH | ||
| from austrakka.utils.helpers.output import call_get_and_print | ||
|
|
||
|
|
||
| @logger_wraps() | ||
| def add_field(identifier: str, field_names: List[str]): | ||
| return api_patch( | ||
| path=f'{ORG_V2_PATH}/{identifier}/Fields/Add', | ||
| data={ | ||
| "fields": field_names | ||
| } | ||
| ) | ||
|
|
||
|
|
||
| @logger_wraps() | ||
| def remove_field(identifier: str, field_names: List[str]): | ||
| return api_patch( | ||
| path=f'{ORG_V2_PATH}/{identifier}/Fields/Remove', | ||
| data={ | ||
| "fields": field_names | ||
| } | ||
| ) | ||
|
|
||
|
|
||
| @logger_wraps() | ||
| def list_field(identifier: str, out_format: str, view_type: str): | ||
| compact_fields = [ | ||
| "columnName", | ||
| "metaDataColumnTypeName", | ||
| "description", | ||
| "primitiveType", | ||
| "isActive", | ||
| ] | ||
| columns = get_viewtype_columns(view_type, compact_fields, []) | ||
| call_get_and_print( | ||
| f'{ORG_V2_PATH}/{identifier}/Fields', | ||
| out_format, | ||
| restricted_cols=columns, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we got metaDataColumnTypeName as a property throughout the rest of the CLI? If we do then we should just fix them all at once (and maybe backend too) but if not, I think it's worth renaming the first two properties to
fieldandfieldTypewhich matches the names of the commands themselvesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost of all our DTOs have
metaDataColumn*rather thanfield*. I'll make a separate card for it. I think we'll probably want to rename the tables as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we do, there is a cleanup card for that