Skip to content

fix: move pnpm.overrides from package.json to pnpm-workspace.yaml#38724

Merged
jeremymeng merged 2 commits into
mainfrom
copilot/update-package-json-and-workspace
Jun 1, 2026
Merged

fix: move pnpm.overrides from package.json to pnpm-workspace.yaml#38724
jeremymeng merged 2 commits into
mainfrom
copilot/update-package-json-and-workspace

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

pnpm no longer reads the pnpm field from package.json. The overrides key was silently ignored, producing a [WARN] on every pnpm install.

Changes

  • package.json: removed the pnpm.overrides field (and the now-empty pnpm object)
  • pnpm-workspace.yaml: added top-level overrides section with the @azure/core-rest-pipeline workspace link

Packages impacted by this PR

Monorepo root (@azure/monorepo)

Issues associated with this PR

#38720

Copilot AI linked an issue May 28, 2026 that may be closed by this pull request
Co-authored-by: jeremymeng <7583839+jeremymeng@users.noreply.github.com>
Copilot AI changed the title [WIP] Update package.json and pnpm-workspace.yaml for pnpm changes fix: move pnpm.overrides from package.json to pnpm-workspace.yaml May 28, 2026
Copilot AI requested a review from jeremymeng May 28, 2026 21:02
@jeremymeng jeremymeng marked this pull request as ready for review May 28, 2026 21:21
@jeremymeng jeremymeng requested a review from a team as a code owner May 28, 2026 21:21
Copilot AI review requested due to automatic review settings May 28, 2026 21:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the monorepo pnpm override configuration from the deprecated package.json pnpm field into pnpm-workspace.yaml, aligning the repo with pnpm’s current workspace settings behavior and resolving the install warning from issue #38720.

Changes:

  • Removed the root pnpm.overrides configuration from package.json.
  • Added the same @azure/core-rest-pipeline link override as a top-level overrides entry in pnpm-workspace.yaml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Removes the deprecated pnpm configuration block from the root package manifest.
pnpm-workspace.yaml Adds the pnpm override in the supported workspace configuration location.

@jeremymeng jeremymeng merged commit 14da700 into main Jun 1, 2026
16 checks passed
@jeremymeng jeremymeng deleted the copilot/update-package-json-and-workspace branch June 1, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning from pnpm install

4 participants