BAH-4635 | [Feature UI] White-Label Override Config Mechanism #252#116
BAH-4635 | [Feature UI] White-Label Override Config Mechanism #252#116hamsavarthiniR-Bahmni wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
| "primary-active": "#004144", | ||
| "link-hover": "#005d5d", | ||
| "link-visited": "#8A3FFC", | ||
| "link-visited-on-dark": "#BE95FF", |
There was a problem hiding this comment.
background variable sounds like a main background color of the application. Should we rename it ?
There was a problem hiding this comment.
can we rename it to background-secondary ? layer-01 is not self-explainatory key
There was a problem hiding this comment.
As discussed earlier, we wanted to follow a white-labelling for branding related config name.
Theming is a feature for switching between white theme, dark theme or as CDS provides we can enable 4 variants of theme. But that is not yet build for bahmni. Here we are just overring default bahmni colors with implementer's brand colors (under white-labelling)
There was a problem hiding this comment.
I just noticed, this white-label-extension.json is for new app... So should we follow the same folder structure as of other configs. openmrs/apps/home/v2/white-label-extension.json
- Rename bahmni-theme.json → bahmni-brand.json to reflect white-labelling/branding purpose rather than theme-switching - Rename 'background' key → 'layer-01' to use the precise Carbon token name and avoid ambiguity with the app's main background Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
hamsavarthiniR-Bahmni
force-pushed
the
BAH-4635
branch
from
af1fb9f to
5642d62
Compare
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Rename brand-extension.json → white-label-extension.json - Rename key layer-01 → background-secondary - Rename key link-visited-on-dark → link-visited-inverse Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
2 participants
No description provided.