forked from Bahmni/default-config
-
Notifications
You must be signed in to change notification settings - Fork 30
BAH-4635 | [Feature UI] White-Label Override Config Mechanism #252 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hamsavarthiniR-Bahmni
wants to merge
7
commits into
master
Choose a base branch
from
BAH-4635
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2e6d18a
BAH-4635 | Add bahmni-theme.json with Carbon token references
hamsavarthiniR-Bahmni 15ac846
BAH-4635 | [Feature UI] White-Label Override Config Mechanism
hamsavarthiniR-Bahmni 5642d62
BAH-4635 | Address PR review comments on white-label config
hamsavarthiniR-Bahmni a28fc85
BAH-4635 | Rename bahmni-brand.json → brand-extension.json
hamsavarthiniR-Bahmni 5c8a935
BAH-4635 | Rename brand-extension.json → white-label-extension.json
hamsavarthiniR-Bahmni d100473
BAH-4635 | Rename to white-label-extension.json; update config keys
hamsavarthiniR-Bahmni da7939b
BAH-4635 | Restore missing primary key in white-label-extension.json
hamsavarthiniR-Bahmni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "primary": "#007d79", | ||
| "primary-text": "#ffffff", | ||
| "primary-hover": "#006b68", | ||
| "primary-active": "#004144", | ||
| "link-hover": "#005d5d", | ||
| "link-visited": "#8A3FFC", | ||
| "link-visited-inverse": "#BE95FF", | ||
| "background-secondary": "#f4f4f4" | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed earlier, we wanted to follow a white-labelling for branding related config name.
Theming is a feature for switching between white theme, dark theme or as CDS provides we can enable 4 variants of theme. But that is not yet build for bahmni. Here we are just overring default bahmni colors with implementer's brand colors (under white-labelling)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed, this white-label-extension.json is for new app... So should we follow the same folder structure as of other configs. openmrs/apps/home/v2/white-label-extension.json