BAH-4754 Command Palette for Bahmni#128
Conversation
lingeswaranTW
force-pushed
the
BAH-4754
branch
4 times, most recently
from
77bd738 to
95f488a
Compare
lingeswaranTW
force-pushed
the
BAH-4754
branch
4 times, most recently
from
3593597 to
8984d62
Compare
| "cmdPaletteNavRegistration": { | ||
| "id": "org.bahmni.commandpalette.nav.registration", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "translationKey": "COMMAND_PALETTE_NAV_REGISTRATION", |
There was a problem hiding this comment.
suggestion: URLs use /bahmni-new/ prefix, but the established convention in this repo for React/new-frontend routes is /bahmni-v2/ (e.g., home/extension.json uses /bahmni-v2/registration/search, clinical/extension.json uses /bahmni-v2/clinical/{{patientUuid}}).
Same applies to lines 22, 73, and 80. If /bahmni-new/ is intentionally replacing /bahmni-v2/, could you note that in the PR description?
| "icon": "fa-registered", | ||
| "newTab": true, | ||
| "order": 1, | ||
| "requiredPrivilege": "app:registration" |
There was a problem hiding this comment.
suggestion: All 7 nav extensions are missing the "type": "link" field. In home/v2/extension.json (the only other v2 extension file in the repo), every entry includes "type": "link". Could you add it to each nav item for consistency?
| "order": 5, | ||
| "requiredPrivilege": "app:ot" | ||
| }, | ||
| "cmdPaletteNavOpenMRS": { |
There was a problem hiding this comment.
suggestion: cmdPaletteNavOpenMRS and cmdPaletteNavBahmniWiki (line 58) use "label" as the sole display field with no translationKey. The other 7 extensions all use translationKey. In existing v2 extensions, label is only used as a supplemental fallback alongside translationKey, never as the sole display string.
This means these two items won't be translatable and have no corresponding entries in the locale files. Consider adding translationKey values and locale entries for both.
| "commandPalette": { | ||
| "trigger": { | ||
| "type": "combination", | ||
| "keys": "cmd+k" |
There was a problem hiding this comment.
suggestion: The cmd modifier maps only to the macOS Command key. On Windows and Linux clinical workstations — the dominant platforms in Bahmni deployments — this won't trigger. Consider adding a ctrl+k fallback or defining both: "keys": ["cmd+k", "ctrl+k"].
2 participants
No description provided.