-
Notifications
You must be signed in to change notification settings - Fork 30
BAH-4754 Command Palette for Bahmni #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "id": "bahmni.commandPalette", | ||
| "extensionPoints": [ | ||
| { | ||
| "id": "org.bahmni.commandpalette.navItem", | ||
| "description": "Command Palette Navigation Items" | ||
| }, | ||
| { | ||
| "id": "org.bahmni.commandpalette.patientAction", | ||
| "description": "Command Palette Patient Actions — rendered as action buttons after patient search" | ||
| } | ||
| ], | ||
| "commandPalette": { | ||
| "trigger": { | ||
| "type": "combination", | ||
| "keys": ["cmd+k", "ctrl+k"] | ||
| }, | ||
| "searchAnnotations": [ | ||
| { | ||
| "prefix": "@phone", | ||
| "label": "Phone", | ||
| "searchType": "patientAttribute", | ||
| "fieldType": "person", | ||
| "fieldsToSearch": ["phoneNumber"] | ||
| }, | ||
| { | ||
| "prefix": "@email", | ||
| "label": "Email", | ||
| "searchType": "patientAttribute", | ||
| "fieldType": "person", | ||
| "fieldsToSearch": ["email"] | ||
| } | ||
| ], | ||
| "patientFields": { | ||
| "primaryFields": ["name", "identifier"], | ||
| "additionalFields": ["age", "gender"] | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| { | ||
| "cmdPaletteNavRegistration": { | ||
| "id": "org.bahmni.commandpalette.nav.registration", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "type": "link", | ||
| "translationKey": "COMMAND_PALETTE_NAV_REGISTRATION", | ||
| "url": "/bahmni-v2/registration/search", | ||
| "icon": "fa-registered", | ||
| "newTab": true, | ||
| "order": 1, | ||
| "requiredPrivilege": "app:registration" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: All 7 nav extensions are missing the
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. resolved |
||
| }, | ||
| "cmdPaletteNavAppointments": { | ||
| "id": "org.bahmni.commandpalette.nav.appointments", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "type": "link", | ||
| "translationKey": "COMMAND_PALETTE_NAV_APPOINTMENTS", | ||
| "url": "/appointments/", | ||
| "icon": "fa-calendar-alt", | ||
| "order": 2, | ||
| "requiredPrivilege": "app:appointments" | ||
| }, | ||
| "cmdPaletteNavCreatePatient": { | ||
| "id": "org.bahmni.commandpalette.nav.createpatient", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "type": "link", | ||
| "translationKey": "COMMAND_PALETTE_NAV_CREATE_PATIENT", | ||
| "url": "/bahmni-v2/registration/patient/new", | ||
| "icon": "fa-user-plus", | ||
| "order": 3, | ||
| "requiredPrivilege": "app:registration" | ||
| }, | ||
| "cmdPaletteNavBedManagement": { | ||
| "id": "org.bahmni.commandpalette.nav.bedmanagement", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "type": "link", | ||
| "translationKey": "COMMAND_PALETTE_NAV_BED_MANAGEMENT", | ||
| "url": "/bahmni/bedmanagement/", | ||
| "icon": "fa-bed", | ||
| "order": 4, | ||
| "requiredPrivilege": "app:adt" | ||
| }, | ||
| "cmdPaletteNavOT": { | ||
| "id": "org.bahmni.commandpalette.nav.ot", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "type": "link", | ||
| "translationKey": "COMMAND_PALETTE_NAV_OT", | ||
| "url": "/bahmni/ot/", | ||
| "icon": "fa-hospital-o", | ||
| "order": 5, | ||
| "requiredPrivilege": "app:ot" | ||
| }, | ||
| "cmdPaletteNavOpenMRS": { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: This means these two items won't be translatable and have no corresponding entries in the locale files. Consider adding
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. resolved |
||
| "id": "org.bahmni.commandpalette.nav.openmrs", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "type": "link", | ||
| "translationKey": "COMMAND_PALETTE_NAV_OPENMRS", | ||
| "label": "OpenMRS", | ||
| "url": "/openmrs", | ||
| "icon": "fa-external-link", | ||
| "newTab": true, | ||
| "order": 6, | ||
| "requiredPrivilege": "app:admin" | ||
| }, | ||
| "cmdPaletteNavBahmniWiki": { | ||
| "id": "org.bahmni.commandpalette.nav.bahmniwiki", | ||
| "extensionPointId": "org.bahmni.commandpalette.navItem", | ||
| "type": "link", | ||
| "translationKey": "COMMAND_PALETTE_NAV_BAHMNI_WIKI", | ||
| "label": "Bahmni Wiki", | ||
| "url": "https://bahmni.atlassian.net/wiki/spaces/BAH/overview", | ||
| "icon": "fa-book", | ||
| "newTab": true, | ||
| "order": 7 | ||
| }, | ||
| "cmdPaletteActionRegistration": { | ||
| "id": "org.bahmni.commandpalette.action.registration", | ||
| "extensionPointId": "org.bahmni.commandpalette.patientAction", | ||
| "translationKey": "COMMAND_PALETTE_ACTION_REGISTRATION", | ||
| "icon": "fa-clipboard-list", | ||
| "pathTemplate": "/bahmni-v2/registration/patient/{{patientUuid}}", | ||
| "order": 1, | ||
| "requiredPrivilege": "app:registration" | ||
| }, | ||
| "cmdPaletteActionClinical": { | ||
| "id": "org.bahmni.commandpalette.action.clinical", | ||
| "extensionPointId": "org.bahmni.commandpalette.patientAction", | ||
| "translationKey": "COMMAND_PALETTE_ACTION_CLINICAL", | ||
| "icon": "fa-stethoscope", | ||
| "pathTemplate": "/bahmni-v2/clinical/{{patientUuid}}", | ||
| "order": 2, | ||
| "requiredPrivilege": "app:clinical" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "COMMAND_PALETTE_NAV_REGISTRATION": "Go to Registration", | ||
| "COMMAND_PALETTE_NAV_CREATE_PATIENT": "Create New Patient", | ||
| "COMMAND_PALETTE_NAV_APPOINTMENTS": "Go to Appointments", | ||
| "COMMAND_PALETTE_NAV_BED_MANAGEMENT": "Bed Management", | ||
| "COMMAND_PALETTE_NAV_OT": "Operating Theatre", | ||
| "COMMAND_PALETTE_NAV_OPENMRS": "OpenMRS", | ||
| "COMMAND_PALETTE_NAV_BAHMNI_WIKI": "Bahmni Wiki", | ||
| "COMMAND_PALETTE_ACTION_REGISTRATION": "Registration", | ||
| "COMMAND_PALETTE_ACTION_CLINICAL": "Clinical" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "COMMAND_PALETTE_NAV_REGISTRATION": "Ir a Registro", | ||
| "COMMAND_PALETTE_NAV_CREATE_PATIENT": "Crear Nuevo Paciente", | ||
| "COMMAND_PALETTE_NAV_APPOINTMENTS": "Ir a Citas", | ||
| "COMMAND_PALETTE_NAV_BED_MANAGEMENT": "Gestión de Camas", | ||
| "COMMAND_PALETTE_NAV_OT": "Quirófano", | ||
| "COMMAND_PALETTE_NAV_OPENMRS": "OpenMRS", | ||
| "COMMAND_PALETTE_NAV_BAHMNI_WIKI": "Bahmni Wiki", | ||
| "COMMAND_PALETTE_ACTION_REGISTRATION": "Registro", | ||
| "COMMAND_PALETTE_ACTION_CLINICAL": "Clínico" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: URLs use
/bahmni-new/prefix, but the established convention in this repo for React/new-frontend routes is/bahmni-v2/(e.g.,home/extension.jsonuses/bahmni-v2/registration/search,clinical/extension.jsonuses/bahmni-v2/clinical/{{patientUuid}}).Same applies to lines 22, 73, and 80. If
/bahmni-new/is intentionally replacing/bahmni-v2/, could you note that in the PR description?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved