[SPEED-3065] Add tests and fixes for constants when strict_types#157
Open
Fladolcetta wants to merge 9 commits into
Open
[SPEED-3065] Add tests and fixes for constants when strict_types#157Fladolcetta wants to merge 9 commits into
strict_types#157Fladolcetta wants to merge 9 commits into
Conversation
Fladolcetta
changed the title
strict_typesstrict_types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
strict_typesissue (see [SPEED-3065] (Blocked by #157) Strict Only #156)mainandpayroll-gatewayhad issues saying that the constant wasmixedwhen in reality it isintChanges:
mixedto infer type inConstFetch.phpdefinein a unit test; there is no generated define file; so update the symbol table to prevent us from trying to remove base path of a non-existent file