Fix hardcoded paths in email export controller to support custom url_prefix - #179
Closed
timujinne wants to merge 1 commit into
Closed
Conversation
…prefix
Updated email_export_controller.ex to use Routes.path() for all redirect URLs
instead of hardcoded /phoenix_kit/ paths. This ensures that the email export
functionality works correctly when a custom url_prefix is configured.
Changes:
- Add PhoenixKit.Utils.Routes alias
- Replace all hardcoded '/phoenix_kit/admin/dashboard' redirects with Routes.path('/admin/dashboard')
- Replace all hardcoded '/phoenix_kit/admin/emails' redirects with Routes.path('/admin/emails')
This fix ensures consistent behavior across all PhoenixKit URLs regardless
of the configured url_prefix setting.
timujinne
deleted the
claude/fix-phoenix-kit-path-generation-011CV4cRDaj1LQptC4ho3SLG
branch
December 1, 2025 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated email_export_controller.ex to use Routes.path() for all redirect URLs instead of hardcoded /phoenix_kit/ paths. This ensures that the email export functionality works correctly when a custom url_prefix is configured.
Changes:
This fix ensures consistent behavior across all PhoenixKit URLs regardless of the configured url_prefix setting.