Skip to content

Fix hardcoded paths in email export controller to support custom url_prefix #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timujinne wants to merge 1 commit into from
Closed

Fix hardcoded paths in email export controller to support custom url_prefix #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/phoenix_kit_web/controllers/email_export_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ defmodule PhoenixKitWeb.Controllers.EmailExportController do
use PhoenixKitWeb, :controller

alias PhoenixKit.Emails
alias PhoenixKit.Utils.Routes

## --- Email Logs Export ---

Expand Down Expand Up @@ -64,7 +65,7 @@ defmodule PhoenixKitWeb.Controllers.EmailExportController do
else
conn
|> put_flash(:error, "Email management is not enabled")
|> redirect(to: "/phoenix_kit/admin/dashboard")
|> redirect(to: Routes.path("/admin/dashboard"))
end
end

Expand Down Expand Up @@ -102,7 +103,7 @@ defmodule PhoenixKitWeb.Controllers.EmailExportController do
else
conn
|> put_flash(:error, "Email management is not enabled")
|> redirect(to: "/phoenix_kit/admin/dashboard")
|> redirect(to: Routes.path("/admin/dashboard"))
end
end

Expand Down Expand Up @@ -131,7 +132,7 @@ defmodule PhoenixKitWeb.Controllers.EmailExportController do
else
conn
|> put_flash(:error, "Email management is not enabled")
|> redirect(to: "/phoenix_kit/admin/dashboard")
|> redirect(to: Routes.path("/admin/dashboard"))
end
end

Expand Down Expand Up @@ -169,17 +170,17 @@ defmodule PhoenixKitWeb.Controllers.EmailExportController do
Ecto.NoResultsError ->
conn
|> put_flash(:error, "Email not found")
|> redirect(to: "/phoenix_kit/admin/emails")
|> redirect(to: Routes.path("/admin/emails"))

ArgumentError ->
conn
|> put_flash(:error, "Invalid email ID")
|> redirect(to: "/phoenix_kit/admin/emails")
|> redirect(to: Routes.path("/admin/emails"))
end
else
conn
|> put_flash(:error, "Email management is not enabled")
|> redirect(to: "/phoenix_kit/admin/dashboard")
|> redirect(to: Routes.path("/admin/dashboard"))
end
end

Expand Down
Loading