Skip to content

Conversation

@Signum21
Copy link

@Signum21 Signum21 commented Mar 13, 2025

Closes #4

  • Misc
    Improve label readability
    Various bug fixes

  • DiscUtils
    Migrated to new fork (the old one was abandoned)
    Added .vdi support

  • Terminal Gui
    Updated to last version
    Gracefully exit from interactive mode (bugfix)

If you need more details on the changes let me know

@binarytrails
Copy link

Amazing work! @Signum21

@CCob
Copy link
Owner

CCob commented Apr 23, 2025

Thanks for the PR. Can these be broken into individual PRs? The terminal GUI one should be fine and the recursive listing as a separate one would also be fine providing a depth can be configured with default sane limits to prevent execution running away from itself over C2 on very deep directory structures.

I'm reluctant for the DiscImage upgrade unless there has been some decent amount of testing with the custom image formats, for example AWS images and raw disk access, as I don't want to break that feature. Unfortunately I don't have the time to test that at the moment myself.

@Signum21
Copy link
Author

Signum21 commented Apr 23, 2025

Unfortunately the DiscUtils update is necessary, the function GetAttributes in the original DiscUtils is significantly slower.
I tested it on a WSL Kali .vhdx and the original DiscUtils takes an excessive amount of time to process the folder /usr/share/exploitdb/exploits/php/webapps/ which contains 21k files.
The function GetAttributes is necessary to continue parsing only directories even if I were to use GetFiles and GetDirectories instead of GetFileSystemEntries, the GetDirectories function is broken and returns Linux symlinks which later lead to an exception trying to list the files.

I tested all file extensions, including raw disk image.
The only thing I haven't tested is AWS which I don't have access to.

No problem in splitting the PR and no problem in adding a limit for the recursion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to dump file list from all volumes

3 participants