Fix punt and kickoff return yard narration - #50
Merged
CalebRose merged 1 commit intoJul 25, 2026
Merged
Conversation
CalebRose
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
play.ResultYardsdirectly when narrating kickoff returns.play.ResultYardsdirectly when narrating punt returns.Why
The engine and stored play-by-play data already use
ResultYardsas the actual return distance. The API was interpreting that value a second time:100 - ResultYards.ResultYards.That caused the human-readable result to disagree with the exported numeric
Yards Gainedand the ensuing field position. In game 9937, all 13 narrated punt/kickoff returns matched the obsolete formulas instead of the direct return value.Impact
Play-by-play pages and CSV exports will display the same punt and kickoff return distance already stored in
ResultYards. Because export narration is generated on request, historical games using the direct-return contract will also display correctly after this API version is deployed.This is intentionally a one-file API formatter fix. It does not change the engine, database schema, Interface, or unrelated play-by-play fields.
Checks
mastercommit844d1c7.go test ./...git diff --check upstream/master...HEADmanagers/StatsManager.go.