fix(ai): add Joi schema validation for Gemini API responses#276
Open
akshara200829-lgtm wants to merge 1 commit into
Open
fix(ai): add Joi schema validation for Gemini API responses#276akshara200829-lgtm wants to merge 1 commit into
akshara200829-lgtm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Description
Related Issue
Closes #245
Summary
The AI endpoints (generate-questions and generate-explanation) were parsing Gemini responses using JSON.parse() but not validating the structure of the returned JSON before sending it to the frontend. This meant incomplete or unexpected Gemini responses could silently pass through and cause rendering issues on the frontend. This PR adds Joi schema validation after parsing to ensure only correctly structured responses reach the client.
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
N/A
Checklist