Skip to content

fix(ai): add Joi schema validation for Gemini API responses #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akshara200829-lgtm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ai): add Joi schema validation for Gemini API responses #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion backend/controllers/aiController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const { GoogleGenerativeAI } = require("@google/generative-ai");
const Joi = require("joi");
const {
conceptExplainPrompt,
questionAnswerPrompt,
Expand All @@ -9,7 +10,6 @@ const Question = require("../models/Question");

const ai = new GoogleGenerativeAI(process.env.GEMINI_API_KEY);


/**
* Generate interview questions and answers using the Gemini AI service.
* @route POST /api/ai/generate-questions
Expand Down Expand Up @@ -103,6 +103,21 @@ const generateInterviewQuestions = async (req, res) => {

try {
const data = JSON.parse(cleanedText);

// Validate Gemini response structure
const questionsSchema = Joi.array().items(
Joi.object({
question: Joi.string().required(),
answer: Joi.string().required(),
})
);
const { error: validationError } = questionsSchema.validate(
Array.isArray(data) ? data : data.question
);
if (validationError) {
return res.status(500).json({ message: "Invalid AI response format", details: validationError.message });
}

if (Array.isArray(data)) {
res.status(200).json({ model: usedModel, question: data });
} else {
Expand Down Expand Up @@ -187,6 +202,17 @@ const generateConceptExplanation = async (req, res) => {

try {
const data = JSON.parse(cleanedText);

// Validate Gemini response structure
const explanationSchema = Joi.object({
title: Joi.string().required(),
explanation: Joi.string().required(),
});
const { error: validationError } = explanationSchema.validate(data);
if (validationError) {
return res.status(500).json({ message: "Invalid AI response format", details: validationError.message });
}

res.status(200).json({ model: usedModel, ...data });
} catch (err) {
res.status(500).json({
Expand Down