test(observability): pin the identifier-field shape (leaf-lane proof) - #54
Merged
Merged
Conversation
w4ffl35
added a commit
that referenced
this pull request
Sep 19, 2026
The leaf lane added in #53 made the twelve heavy jobs *skip* on a leaf change, assuming a skipped job satisfies a required check. A ruleset does not treat a skipped job as satisfied, so #54 (a leaf-only PR) came back BLOCKED even though `changes` and `leaf` passed. Fix: the five required jobs (`lint`, `test (3.12)`, `core-boundary`, `published-surfaces`, `packaging-guards`) now always run; only the seven non-required heavy jobs (`test-deploy`, `hub`, `extras`, `blocked-deps`, `docs`, `client`, `headless`) skip on a leaf change. `test` keeps `needs: changes` and narrows its matrix to `3.12` when leaf, so the required `test (3.12)` still reports while three cells are cut. The `leaf` job stays as a fast extra signal; it is not a required check (the ruleset was reverted to its original five). Refs Capsize-Games/hq#14
w4ffl35
force-pushed
the
test/observability-identifier-fields
branch
from
September 19, 2026 18:39
b963bee to
3ed9272
Compare
Guards the capsize_commons.logging adoption: the three correlation keys are carried and an unrelated extra= key cannot leak into the payload. Leaf-only change (tests/test_observability_*.py), used to exercise the CI fast lane added in #53. Refs Capsize-Games/hq#14
w4ffl35
force-pushed
the
test/observability-identifier-fields
branch
from
September 19, 2026 18:55
3ed9272 to
13b3b21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaf-only change (touches only
tests/test_observability_logging.py) to prove the CI fast lane added in #53: thechangesjob should mark itleaf, the twelve self-hosted jobs should skip (reporting success), and the torch-freeleafjob should be the real gate. Timing is reported on hq#14. Refs Capsize-Games/hq#14.