Skip to content

fix: secure password storage and authentication using bcrypt#1184

Open
tylrx404 wants to merge 1 commit into
Charushi06:mainfrom
tylrx404:fix/password-hashing-auth
Open

fix: secure password storage and authentication using bcrypt#1184
tylrx404 wants to merge 1 commit into
Charushi06:mainfrom
tylrx404:fix/password-hashing-auth

Conversation

@tylrx404

Copy link
Copy Markdown

Summary

This PR fixes a security vulnerability where user passwords were stored and compared in plain text.

Changes Made

  • Added bcrypt password hashing during user registration.
  • Replaced plain-text password comparison with bcrypt.compare() during login.
  • Updated authentication flow to use secure password verification.
  • Preserved existing authentication behavior and error handling.

Testing

  • Verified successful account creation with hashed password storage.
  • Verified login succeeds with correct credentials.
  • Verified login fails with incorrect credentials.
  • Confirmed passwords are no longer stored in plain text in the database.

Fixes #1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Passwords stored and compared in plain text

1 participant