Skip to content

fix: secure password storage and authentication using bcrypt #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tylrx404 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: secure password storage and authentication using bcrypt #1184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
require('dotenv').config();
const express = require('express');
const cors = require('cors');
const bcrypt = require('bcrypt');
const { db, initDb } = require('./database');
const { GoogleGenAI } = require('@google/genai');
const path = require('path');
Expand Down Expand Up @@ -555,7 +556,7 @@ Text: "${text}"
// ================= AUTH =================

// SIGNUP
app.post('/api/auth/signup', (req, res) => {
app.post('/api/auth/signup', async(req, res) => {
const { email, password } = req.body;

if (!email || !password) {
Expand All @@ -566,10 +567,11 @@ app.post('/api/auth/signup', (req, res) => {

const id = 'user_' + Date.now();

const hashedPassword = await bcrypt.hash(password, 10);
db.run(
`INSERT INTO users (id, email, password)
VALUES (?, ?, ?)`,
[id, email, password],
[id, email, hashedPassword],
function(err) {

if (err) {
Expand All @@ -594,7 +596,7 @@ app.post('/api/auth/signup', (req, res) => {
});

// LOGIN
app.post('/api/auth/login', (req, res) => {
app.post('/api/auth/login',async (req, res) => {
const { email, password } = req.body;

if (!email || !password) {
Expand All @@ -606,20 +608,29 @@ app.post('/api/auth/login', (req, res) => {
db.get(
`SELECT * FROM users WHERE email = ?`,
[email],
(err, user) => {
async (err, user) => {

if (err) {
return res.status(500).json({
error: err.message
});
}

if (!user || user.password !== password) {
if (!user) {
return res.status(401).json({
error: 'Invalid email or password'
});
}
const isValid = await bcrypt.compare(
password,
user.password
);

if (!isValid) {
return res.status(401).json({
error: 'Invalid email or password'
});
}
res.json({
success: true,
email: user.email
Expand Down