a11y: accessible labels and validation ARIA on form inputs#85
Merged
Conversation
- ExerciseRow: aria-label="Øvelsenavn" on exercise name input - ExerciseRow: aria-label, aria-invalid, aria-describedby on sets/reps inputs; off-screen error span announces "Ugyldig antall" to screen readers when invalid - MusclePicker: id on help text span + aria-describedby on picker wrapper so instructions are read on focus; aria-hidden on decorative body outline <g> and FRONT/BACK <text> Closes #70, #77, #83 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds programmatic labels and validation state to the custom inputs used throughout the app so screen reader users know what each field is for and hear errors without manually hunting for them.
aria-label="Øvelsenavn"on the exercise name input;aria-label,aria-invalid, andaria-describedbyon sets/reps inputs; an off-screen error<span>announces "Ugyldig antall – skriv inn 1 til 99" when a value is invalidid; the picker wrapper getsaria-describedbypointing to it so screen readers read the instructions on focus;aria-hidden="true"added to the decorative body outline<g>and FRONT/BACK<text>(same pattern asbodymap.jsxin PR a11y: set HTML lang, add reduced-motion CSS, hide decorative SVG elements #84)Test plan
Closes #70, #77, #83
🤖 Generated with Claude Code