Skip to content

a11y: accessible labels and validation ARIA on form inputs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristopherRotnes merged 1 commit into from
May 3, 2026
Merged

a11y: accessible labels and validation ARIA on form inputs #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 43 additions & 27 deletions app/src/components/ExerciseRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export default function ExerciseRow({
{editingName ? (
<input
autoFocus
aria-label="Øvelsenavn"
value={exercise.name}
onChange={(e) => onChange({ name: e.target.value, standardName: e.target.value })}
onBlur={() => setEditingName(false)}
Expand Down Expand Up @@ -77,33 +78,48 @@ export default function ExerciseRow({
</div>

<div style={{ display: "flex", alignItems: "center", gap: 4, flexShrink: 0 }}>
{["sets", "reps"].map(field => (
<div key={field} style={{ display: "flex", alignItems: "center", gap: 2 }}>
<input
type="number"
min="1"
max="99"
placeholder="–"
value={exercise[field] || ""}
onChange={e => onChange({ [field]: e.target.value })}
style={{
width: 40,
height: 28,
padding: "0 4px",
background: "var(--cds-field-01)",
border: `1px solid ${validateNumbers && isInvalidNum(exercise[field]) ? "var(--cds-support-error)" : "var(--cds-border-strong-01)"}`,
color: validateNumbers && isInvalidNum(exercise[field]) ? "var(--cds-support-error)" : "var(--cds-text-primary)",
fontFamily: "var(--cds-font-sans)",
fontSize: 12,
outline: "none",
textAlign: "center",
}}
/>
<span style={{ fontSize: 11, color: "var(--cds-text-secondary)" }}>
{field === "sets" ? "sett" : "reps"}
</span>
</div>
))}
{["sets", "reps"].map(field => {
const isFieldInvalid = validateNumbers && isInvalidNum(exercise[field]);
const errorId = `err-${exercise.id}-${field}`;
return (
<div key={field} style={{ display: "flex", alignItems: "center", gap: 2, position: "relative" }}>
<input
type="number"
min="1"
max="99"
placeholder="–"
aria-label={field === "sets" ? `Sett for ${exercise.name || "øvelse"}` : `Reps for ${exercise.name || "øvelse"}`}
aria-invalid={isFieldInvalid || undefined}
aria-describedby={isFieldInvalid ? errorId : undefined}
value={exercise[field] || ""}
onChange={e => onChange({ [field]: e.target.value })}
style={{
width: 40,
height: 28,
padding: "0 4px",
background: "var(--cds-field-01)",
border: `1px solid ${isFieldInvalid ? "var(--cds-support-error)" : "var(--cds-border-strong-01)"}`,
color: isFieldInvalid ? "var(--cds-support-error)" : "var(--cds-text-primary)",
fontFamily: "var(--cds-font-sans)",
fontSize: 12,
outline: "none",
textAlign: "center",
}}
/>
<span style={{ fontSize: 11, color: "var(--cds-text-secondary)" }}>
{field === "sets" ? "sett" : "reps"}
</span>
{isFieldInvalid && (
<span
id={errorId}
style={{ position: "absolute", left: "-9999px", width: 1, height: 1, overflow: "hidden" }}
>
Ugyldig antall – skriv inn 1 til 99
</span>
)}
</div>
);
})}
</div>

<Button
Expand Down
10 changes: 6 additions & 4 deletions app/src/components/MusclePicker.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function MusclePickerView({ view, primary, secondary, onToggle, instanceId }) {
</pattern>
</defs>

<g style={{ fill: "var(--cds-layer-02)", stroke: "var(--cds-border-subtle-01)" }} strokeWidth="0.6">
<g aria-hidden="true" style={{ fill: "var(--cds-layer-02)", stroke: "var(--cds-border-subtle-01)" }} strokeWidth="0.6">
<circle cx="80" cy="21" r="17" />
<polygon points="74,37 86,37 87,50 73,50" />
<path d={BODY_PATH} />
Expand Down Expand Up @@ -66,7 +66,7 @@ function MusclePickerView({ view, primary, secondary, onToggle, instanceId }) {
);
})}

<text x="80" y="352" textAnchor="middle" fontSize="7.5"
<text aria-hidden="true" x="80" y="352" textAnchor="middle" fontSize="7.5"
fontFamily="var(--cds-font-mono)" letterSpacing="2"
style={{ fill: "var(--cds-text-secondary)" }}>
{view === "front" ? "FRONT" : "BACK"}
Expand All @@ -92,16 +92,18 @@ export default function MusclePicker({ primary = [], secondary = [], onChange, i
onChange({ primary: nextPrimary, secondary: nextSecondary });
};

const helpId = `muscle-help-${instanceId}`;

return (
<div>
<div style={{ display: "flex", gap: 4, marginBottom: 8, flexWrap: "wrap" }}>
<Tag type="green" size="sm">Primær ({primary.length})</Tag>
<Tag type="blue" size="sm">Sekundær ({secondary.length})</Tag>
<span style={{ fontSize: 11, color: "var(--cds-text-secondary)", alignSelf: "center", marginLeft: 4 }}>
<span id={helpId} style={{ fontSize: 11, color: "var(--cds-text-secondary)", alignSelf: "center", marginLeft: 4 }}>
Klikk muskel: av → primær → sekundær → av
</span>
</div>
<div style={{ display: "flex", gap: 8 }}>
<div aria-describedby={helpId} style={{ display: "flex", gap: 8 }}>
{["front", "back"].map(view => (
<div key={view} style={{ flex: 1, background: "var(--cds-layer-01)", border: "1px solid var(--cds-border-subtle-01)", padding: "6px 4px" }}>
<MusclePickerView
Expand Down
Loading