Skip to content

Highlight retry/patching-loop log messages in amber #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaja-s wants to merge 1 commit into from
Closed

Highlight retry/patching-loop log messages in amber #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions codeplain_REST_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ def _handle_retry_logic(
connection_error_type = "Network error" if is_connection_error else "Error"
if attempt < num_retries:
if not silent:
self.console.debug(f"{connection_error_type} on attempt {attempt + 1}/{num_retries + 1}: {error}")
self.console.debug(f"Retrying in {retry_delay} seconds...")
self.console.debug(
f"[#FFB454]↻ {connection_error_type} on attempt {attempt + 1}/{num_retries + 1}: {error}. "
f"Retrying in {retry_delay} seconds...[/#FFB454]"
)
time.sleep(retry_delay)
# Exponential backoff
return retry_delay * 2
Expand Down
2 changes: 1 addition & 1 deletion render_machine/actions/fix_conformance_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def execute(self, render_context: RenderContext, previous_action_payload: Any |
render_context.conformance_tests_running_context.conflicting_module_name = current_testing_module_name
render_context.conformance_tests_running_context.conflicting_frid = current_testing_frid
console.info(
f"Potential conflicting functionalities detected while fixing conformance tests for functionality {current_testing_frid} in module {current_testing_module_name}."
f"[#FFB454]Potential conflicting functionalities detected while fixing conformance tests for functionality {current_testing_frid} in module {current_testing_module_name}.[/#FFB454]"
)

if issue_reason_code == self.ISSUE_REASON_CODE_CONFORMANCE_TESTS:
Expand Down
4 changes: 2 additions & 2 deletions render_machine/actions/render_functional_requirement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |

if render_context.frid_context.functional_requirement_render_attempts > 1:
console.info(
f"Unittests could not be fixed after rendering the functionality. "
f"Restarting rendering functionality {render_context.frid_context.frid} from scratch."
f"[#FFB454]↻ Unittests could not be fixed after rendering the functionality. "
f"Restarting rendering functionality {render_context.frid_context.frid} from scratch.[/#FFB454]"
)

render_utils.revert_changes_for_frid(render_context)
Expand Down
5 changes: 3 additions & 2 deletions render_machine/render_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,10 @@ def _on_unit_test_limit_exceeded_in_conformance_tests(self):
self.dispatch_error(error_msg)
else:
console.info(
f"Failed to adjust the unit tests after implementation code was updated while fixing the conformance tests for functionality {self.frid_context.frid}."
f"[#FFB454]↻ Failed to adjust the unit tests after implementation code was updated while fixing the "
f"conformance tests for functionality {self.frid_context.frid}. "
f"Restarting rendering the functionality {self.frid_context.frid} from scratch.[/#FFB454]"
)
console.info(f"Restarting rendering the functionality {self.frid_context.frid} from scratch.")
self.machine.dispatch(triggers.RESTART_FRID_PROCESSING)

def _on_unit_test_limit_exceeded_in_refactoring(self):
Expand Down
8 changes: 4 additions & 4 deletions render_machine/render_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,12 @@ def _drain_stdout() -> None:

if proc.returncode != 0:
if frid is not None:
console.debug(
f"The {script_type} script for functionality ID {frid} of module {module} has failed. Initiating the patching mode to automatically correct the discrepancies."
console.info(
f"[#FFB454]↻ The {script_type} script for functionality ID {frid} of module {module} has failed. Initiating the patching mode to automatically correct the discrepancies.[/#FFB454]"
)
else:
console.debug(
f"The {script_type} script has failed. Initiating the patching mode to automatically correct the discrepancies."
console.info(
f"[#FFB454]↻ The {script_type} script has failed. Initiating the patching mode to automatically correct the discrepancies.[/#FFB454]"
)
else:
if frid is not None:
Expand Down
Loading