Highlight retry/patching-loop log messages in amber - #255
Closed
kaja-s wants to merge 1 commit into
Closed
Conversation
pedjaradenkovic
left a comment
pedjaradenkovic
left a comment
Contributor
There was a problem hiding this comment.
Hey @kaja-s
Thanks for providing this PR. I reviewed it and noticed that the way we approach this logging is not the best because it includes the presentation logic into the logs.
I made a PR that fixes this and includes the changes I made. With that PR, when you want to log something and print it in color on TUI you just provide color as a param. Logs and headless runs stay clean of the colors.
Please test the new PR and if it looks good you can close this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#FFB454) with a retry glyph (↻) so it's clear at a glance where the renderer is struggling and looping, mirroring the existing green success styling.