Color retry/success log messages via a console color param, keeping file logs plain text - #256
Merged
Merged
Conversation
pedjaradenkovic
force-pushed
the
feature/colored-log-messages
branch
from
July 20, 2026 17:03
511afbe to
a7643d0
Compare
pedjaradenkovic
force-pushed
the
feature/colored-log-messages
branch
from
July 20, 2026 17:13
a7643d0 to
df0bfa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Resolves #247, supersedes #255.
#255 embedded Rich markup (
[#FFB454]…[/#FFB454]) directly in log message strings.Plain2CodeConsolelogs and prints the same string, so the markup tags landed verbatim incodeplain.logand headless output, and bracketed content in interpolated error text (e.g.[/x]) could crash Rich's markup parsing.Colors now travel out-of-band: console methods take a
color=param, the color reaches the TUI as alog_colorrecord attribute, and the file log always receives plain text. The pre-existing inline-markup call sites were migrated to the same mechanism, and message rendering no longer interprets log text as markup anywhere.