This repository was archived by the owner on Jul 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
DeID improvements #541
Merged
Merged
DeID improvements #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or train / test files
mart-r
suggested changes
Jun 2, 2025
Collaborator
mart-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments that I think should be addressed (i.e duplicate/typod key, remaining old doc string), the rest of it is more optional I'd say.
Though I do feel like the 2 comments regarding cui2preferred_name as well as the one regarding using filter make sense to implement as well.
mart-r
approved these changes
Jun 4, 2025
Collaborator
mart-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests as well - great!
All good on my side.
10 tasks
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jul 1, 2025
DeID improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements for fine-tuning and using the de-id in a pipeline:
DeIdModel.train